Ensure cad_component.footprinter_string is set when footprint is a string (fix 0402 resistor)#2075
Open
Ensure cad_component.footprinter_string is set when footprint is a string (fix 0402 resistor)#2075
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
footprint="0402"were not having theircad_component.footprinter_stringpopulated when acadModelwas provided, which broke footprint tracking and external footprint logic.Description
footprintinto the createdcad_componentby changing the assignment tofootprinter_string: typeof footprint === "string" ? footprint : undefinedinNormalComponent.doInitialCadModelRender, and add a regression testtests/components/normal-components/resistor-cad-component-footprinter-string.test.tsxthat validates a resistor withfootprint="0402"and acadModelproduces acad_componentwithfootprinter_string: "0402".Testing
bun test tests/components/normal-components/resistor-cad-component-footprinter-string.test.tsxandbun test tests/footprint/footprint-library-map-cadmodel.test.tsx(both passed), ranbunx tsc --noEmit(passed), and ranbun run format.Codex Task