Support standard=usb_c for connector using parts-engine#2090
Support standard=usb_c for connector using parts-engine#2090MustafaMulla29 merged 16 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
MustafaMulla29
force-pushed
the
feat/usb_c
branch
from
9d3c50e to
3f9ef44
Compare
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
this is pretty good, this is not an easy PR, but you're doing pretty good, let's just polish it up we're close
| circuitJson, | ||
| ) | ||
| this.addAll(fpComponents) | ||
| this._markDirty("InitializePortsFromChildren") |
There was a problem hiding this comment.
do you have to mark this dirty? That is for revisiting a render method
| } | ||
|
|
||
| updateInitializePortsFromChildren(): void { | ||
| this.initPorts() |
There was a problem hiding this comment.
i suspect you don't need this because there's no need to mark this phase dirty because of the render order
There was a problem hiding this comment.
Tests are failing if I remove this, I think if we remove this, then it requires a broader changes in other files
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
this looks good, just see my comment on the dirty phase marking, we don't want to mark it dirty unless we have to
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
This is an ok start (rename the render phase before merge!!!) but you need to standard the pinLabels in the next PR, whenever using usb_c the user should expect to have the same pinLabels/connections
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
3 participants
No description provided.