feat(connector): resolve usb_c pinLabels deterministically (defaults + user overrides)#2092
Closed
MustafaMulla29 wants to merge 3 commits intomainfrom
Closed
feat(connector): resolve usb_c pinLabels deterministically (defaults + user overrides)#2092MustafaMulla29 wants to merge 3 commits intomainfrom
MustafaMulla29 wants to merge 3 commits intomainfrom
Conversation
…+ user overrides)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
MustafaMulla29
commented
Apr 2, 2026
| }) | ||
| } | ||
|
|
||
| override _getPinCount(): number { |
Contributor
Author
There was a problem hiding this comment.
@seveibar is this needed? otherwise the default schematic for usb_c will not render pinLabels and ports in schematics
Contributor
There was a problem hiding this comment.
Im not completely sure, you actually need to commit several usb c circuit json representations from the real world to this repo as examples so that we can test our handling i think
seveibar
reviewed
Apr 2, 2026
Contributor
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
The tests are getting sloppy, you should pull in a real usb footprint.
a simpler approach is to modify/map the circuit json before its converted to a footprint elements etc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.