Fix custom sel.net typing and add regression coverage#2093
Open
mohan-bee wants to merge 1 commit intotscircuit:mainfrom
Open
Fix custom sel.net typing and add regression coverage#2093mohan-bee wants to merge 1 commit intotscircuit:mainfrom
mohan-bee wants to merge 1 commit intotscircuit:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
lib/components/base-components/PrimitiveComponent/preprocessSelector.ts
Outdated
Show resolved
Hide resolved
mohan-bee
force-pushed
the
fix-sel-custom-net-typing-clean
branch
from
63a2c21 to
350fa43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent benchmark runs repeatedly hit TypeScript errors like Property 'USB_DP_RAW' does not exist on type 'NetSelFn' because the distinction between built-in and custom net selectors was not
obvious in core: built-in nets use the shorthand sel.net.GND, while custom nets require the typed callable form sel.net<"USB_DP_RAW" | "USB_DM_RAW">().USB_DP_RAW.
This PR makes that contract explicit in the source of truth, adds regression coverage, and improves selector error messages so users are pointed to the correct custom-net syntax instead of discovering it through trial and error.