Fix USB-C connector pin-label normalization and schematic render lifecycle#2095
Open
MustafaMulla29 wants to merge 2 commits intomainfrom
Open
Fix USB-C connector pin-label normalization and schematic render lifecycle#2095MustafaMulla29 wants to merge 2 commits intomainfrom
MustafaMulla29 wants to merge 2 commits intomainfrom
Conversation
…cycle; add fixture-based tests including custom pinLabels
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
seveibar
reviewed
Apr 2, 2026
Contributor
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
you shouldn't canonicalize the pin numbers, just the labels
and you can ignore the shell.
Basically, don't change anything except add aliases to existing pins
seveibar
reviewed
Apr 2, 2026
tests/components/normal-components/parts-engine-fetch-circuit-json-custom-pinlabels.test.tsx
Outdated
Show resolved
Hide resolved
seveibar
reviewed
Apr 2, 2026
seveibar
reviewed
Apr 2, 2026
Contributor
There was a problem hiding this comment.
this is really complex! i don't think you need this much complexity tbh, you just need to add the aliases by having a common set of mappings, you don't need to remap pin numbers, which aren't expected to be consistent. However, i ALWAYS expect DM and DP (data minus and data positive) and CC1, GND1, GND2 etc.
MustafaMulla29
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.