Support multiple PCB contacts for one logical port#2144
Open
ShiboSoftwareDev wants to merge 3 commits intotscircuit:mainfrom
Open
Support multiple PCB contacts for one logical port#2144ShiboSoftwareDev wants to merge 3 commits intotscircuit:mainfrom
ShiboSoftwareDev wants to merge 3 commits intotscircuit:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
seveibar
reviewed
Apr 16, 2026
| } | ||
|
|
||
| private _getMatchedPcbPortId(): string | undefined { | ||
| return this.matchedPort?.getPcbPortIdForMatchedComponent(this) ?? undefined |
seveibar
reviewed
Apr 16, 2026
Contributor
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
a port has multiple port ids? No way- we would never be able to maintain this
Contributor
|
This is not an easy problem to solve but we also can't hack it- otherwise we will never be able to fix this codebase. There are other solutions, for example introducing the concept of "internally connected ports" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows a single logical port to own multiple non-overlapping PCB pads or plated holes, so composite terminals like battery clips can route through any matching contact instead of being treated as ambiguous.
Adds per-contact pcb_port tracking on Port, attaches pads/holes to their specific PCB port, and updates trace-by-trace routing to choose the closest PCB contact candidate.
Updates footprint port matching to prefer raw pin hints like pin1 over aliases, and moves true multi-logical-port selector
ambiguity detection into trace port resolution.