Also consider inferred vias in trace-to-pad clearance relaxation#9
Merged
imrishabh18 merged 1 commit intoMay 6, 2026
Merged
Conversation
Abse2001
approved these changes
May 6, 2026
seveibar
approved these changes
May 6, 2026
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
route.vias, missing implied vias created by layer transitions where the route point has the same XY but differentzvalues.viasarray.Description
getRouteViaCentersto collect via centers from both explicitroute.viasand inferred via locations at zero-length layer transitions. (lib/solvers/GlobalDrcForceImproveSolver/traceToPadClearanceRelaxation.ts)getRouteViaCentersinstead of iterating onlyotherRoute.vias, so trace clearance considers inferred vias as blockers.moves a trace until its edge clears an inferred different-net via edgeto verify a trace is nudged away from an inferred different-net via center. (tests/solver-route-behavior.test.ts)Testing
tests/solver-route-behavior.test.tscovering the inferred via case; test logic is present in the repo.bun testandbun test tests/solver-route-behavior.test.ts, but automated execution failed due to missing external dependencies (@tscircuit/math-utils, etc.) in the execution environment, so tests could not be executed here.git diff --checkand committed the changes asHandle inferred vias in trace clearance relaxation.Codex Task