refactor: update renderGLTFToPNG function and dependencies in packagejson#296
Merged
rushabhcodes merged 1 commit intoJun 14, 2026
Conversation
rushabhcodes
requested review from
ShiboSoftwareDev and
techmannih
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
MustafaMulla29
approved these changes
Jun 11, 2026
MustafaMulla29
left a comment
MustafaMulla29
left a comment
Contributor
There was a problem hiding this comment.
Am not sure why we need this to change, take approval from rishabh as well!
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
seveibar
approved these changes
Jun 14, 2026
|
Thank you for your contribution! 🎉 PR Rating: ⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
poppygldependency and refactors the test code to use the newrenderGLTFToPNGFromGLBAPI, replacing the deprecatedrenderGLTFToPNGBufferFromGLBBuffer. It also updates the expected return type fromBuffertoUint8Arraywhere appropriate.Dependency update:
poppyglfrom version^0.0.20to^0.0.24inpackage.jsonto use the latest features and API changes.Test code refactoring for new API:
renderGLTFToPNGBufferFromGLBBufferwithrenderGLTFToPNGFromGLBintests/helpers/render-footprint.ts,tests/snapshots/footprint-plated-hole.test.tsx, andtests/snapshots/jstzh1_5mm.test.tsx. [1] [2] [3]renderFootprintandrenderComponentTopViewfromPromise<Buffer>toPromise<Uint8Array>to match the new API. [1] [2]renderGLTFToPNGFromGLBAPI in the relevant test files. [1] [2] [3] [4]