Remove disableAutoFocus in favor of focusOnHover={false}#903
Open
varyavsksm-sudo wants to merge 1 commit into
Open
Remove disableAutoFocus in favor of focusOnHover={false}#903varyavsksm-sudo wants to merge 1 commit into
disableAutoFocus in favor of focusOnHover={false}#903varyavsksm-sudo wants to merge 1 commit into
Conversation
varyavsksm-sudo
requested review from
Abse2001,
ShiboSoftwareDev and
seveibar
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
PCBViewerruntime prop has already migrated fromdisableAutoFocustofocusOnHoveronmain. The only remaining legacy surface was theDisabledAutoFocusexample fixture insrc/examples/2025/board.fixture.tsx, which still carried the old naming and did not express the behavior through the new prop.This PR finishes the migration:
DisabledAutoFocusfixture export toFocusOnHoverDisabled.focusOnHover={false}to<PCBViewer />, matching the prop API already used by the other fixtures (hover-behavior.fixture.tsx,plated-hole-core.fixture.tsx).No runtime behavior changes for consumers —
focusOnHoveralready defaults tofalse; this just removes the lastdisableAutoFocus-flavored naming and documents the equivalent behavior via the supported prop./claim #163
Fixes #163.