Skip to content

add stepUrl to CadModelBase #620

Merged
MustafaMulla29 merged 4 commits intomainfrom
fix/step
Mar 24, 2026
Merged

add stepUrl to CadModelBase #620
MustafaMulla29 merged 4 commits intomainfrom
fix/step

Conversation

@MustafaMulla29
Copy link
Copy Markdown
Contributor

No description provided.

@MustafaMulla29 MustafaMulla29 requested a review from seveibar March 24, 2026 06:29
Copy link
Copy Markdown
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't the right approach, i think zod has a merge that should be used instead

@MustafaMulla29 MustafaMulla29 requested a review from seveibar March 24, 2026 06:33
Copy link
Copy Markdown
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not create a CadModelObjStep, that is really really hacky

@MustafaMulla29 MustafaMulla29 requested a review from seveibar March 24, 2026 07:05
Copy link
Copy Markdown
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove test i think

@MustafaMulla29 MustafaMulla29 changed the title fix: preserve stepUrl when cadModel has both objUrl and stepUrl add stepUrl to CadModleBase Mar 24, 2026
@MustafaMulla29 MustafaMulla29 changed the title add stepUrl to CadModleBase add stepUrl to CadModelBase Mar 24, 2026
@MustafaMulla29 MustafaMulla29 merged commit 38caaa2 into main Mar 24, 2026
4 checks passed
@MustafaMulla29 MustafaMulla29 deleted the fix/step branch March 24, 2026 07:08
@tscircuitbot
Copy link
Copy Markdown
Contributor


Thank you for your contribution! 🎉

PR Rating: ⭐⭐
Impact: Minor

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants