Tune crossing-via estimation, clamp probability, and add tests#645
Closed
Tune crossing-via estimation, clamp probability, and add tests#645
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
calculateNodeProbabilityOfFailureto0.65,0.3, and0.32fornumSameLayerCrossings,numEntryExitLayerChanges, andnumTransitionCrossingsrespectively.const estUsedCapacity = (estNumVias / 1.8) ** 1.15to reflect the retuned scaling and exponent.Math.max(0, Math.min(1, approxProb))so results are always in[0,1].tests/solvers/calculateCrossingProbabilityOfFailure.test.tsthat validate target behavior, single-layer behavior, coefficient math, and clamping of very large values.Testing
bun:testincludingcalculateCrossingProbabilityOfFailure.test.ts, and all tests passed.calculateNodeProbabilityOfFailurereturning0for target nodes,1for single-layer nodes with crossings, correct coefficient usage and formula, and clamping large estimates to1.Codex Task