Prefer node-box distance for assigning connection endpoints#655
Closed
Prefer node-box distance for assigning connection endpoints#655
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🏃 Benchmark This PRRun benchmarks by commenting on this PR: Examples:
Any PR whose title contains |
Contributor
Author
|
/benchmark AutoroutingPipelineSolver3_HgPortPointPathing |
🏃 Autorouting Benchmark⏳ Running benchmark on 🔗 Workflow: View run |
Contributor
Author
|
/benchmark AutoroutingPipelineSolver3_HgPortPointPathing |
🏃 Autorouting Benchmark Results📊 PR Results📊 Main Branch Results📦 Artifact: https://github.com/tscircuit/tscircuit-autorouter/actions/runs/23021737257 |
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
pointsToConnectcan lie outside obstacle centers so choosing the nearest node by center distance caused endpoints to be attributed to the wrong node in some scenarios (e.g.circuit018).Description
getDistanceToNodeBoxhelper to compute the shortest distance from a point to a node's rectangular box andgetNodeForConnectionPointto pick the best node by box distance (center distance used as a tiebreaker).getConnectionsWithNodeswith the new box-distance-based selection.tests/bugs/get-connections-with-nodes-prefers-box-distance.test.tsthat reproduces the center-vs-box mismatch and asserts the expected node assignment.lib/solvers/PortPointPathingSolver/getConnectionsWithNodes.tsand new testtests/bugs/get-connections-with-nodes-prefers-box-distance.test.ts.Testing
bun test tests/bugs/get-connections-with-nodes-prefers-box-distance.test.ts tests/bugs/missing-portpoints-001.test.tsand both tests passed (2 pass, 0 fail).runTaskchecks forAssignableAutoroutingPipeline3andAutoroutingPipelineSolver3_HgPortPointPathingoncircuit018, and both solvers completed withdidSolve: true(relaxed DRC checks returnedrelaxedDrcPassed: falsefor the scenario).Codex Task