Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🏃 Benchmark This PRRun benchmarks by commenting on this PR: Examples:
Any PR whose title contains |
|
/benchmark |
🏃 Autorouting Benchmark Results📊 PR Results📊 Main Branch Results📦 Artifact: https://github.com/tscircuit/tscircuit-autorouter/actions/runs/23082987508 |
| hyperParameters | ||
| }) | ||
| solver.MAX_ITERATIONS = 20_000_000 * this.effort | ||
| solver.MAX_ITERATIONS *= this.effort |
There was a problem hiding this comment.
Critical bug: MAX_ITERATIONS multiplication operator changed from assignment to compound assignment.
The old code was:
solver.MAX_ITERATIONS = 20_000_000 * this.effortThe new code is:
solver.MAX_ITERATIONS *= this.effortThis changes the behavior from setting an explicit value to multiplying whatever default value HighDensityA03Solver has for MAX_ITERATIONS. If the default is not 20_000_000, this will cause different iteration limits and potentially affect solver performance or correctness.
Fix: Change to explicit assignment like the A01 solver above it, or verify that multiplying the default value is intentional:
solver.MAX_ITERATIONS = 20_000_000 * this.effort| solver.MAX_ITERATIONS *= this.effort | |
| solver.MAX_ITERATIONS = 20_000_000 * this.effort |
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
|
/benchmark |
🏃 Autorouting Benchmark Results📊 Main Branch Results📊 PR Results📦 Artifact: https://github.com/tscircuit/tscircuit-autorouter/actions/runs/23095138474 |
|
/benchmark |
🏃 Autorouting Benchmark Results📊 Main Branch Results📊 PR Results📦 Artifact: https://github.com/tscircuit/tscircuit-autorouter/actions/runs/23095245386 |
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
No description provided.