Fix cramped port point HD polyline acceptance#700
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🏃 Benchmark This PRRun benchmarks by commenting on this PR: Everything after Examples:
Any PR whose title contains |
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
|
This PR was closed because it has been inactive for 1 day since being marked as stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
computeRequiredMinGapBtwPolyLinesto estimate a per-pair minimal required gap based on fixed start/end port spacing so the solver doesn't demand the globalobstacleMarginwhen it is impossible due to fixed endpoints (added toMultiHeadPolyLineIntraNodeSolver).checkIfSolvedto compare computedminGapsagainst the per-pair required minimums rather than the globalobstacleMarginfor all pairs, allowing acceptance when the only bottleneck is unavoidable endpoint spacing.tests/multi-head-hd/hdpolyline12-cramped-port-points.test.tsxreproducing the reported cramped mixed-layer case and asserting the solver now solves it.Testing
bun test tests/multi-head-hd/hdpolyline12-cramped-port-points.test.tsxand the test passed (solver now solves the cramped case).bun test tests/multi-head-hd/same-net-coincident.test.tsx tests/multi-head-hd/hdpolyline12-cramped-port-points.test.tsxand both tests passed.bunx tsc --noEmitwhich succeeded.bun run format(biome) which completed.Codex Task