Skip to content

Migrate FixedTopologyHighDensityIntraNodeSolver to fixed-via-hypergraph-solver#711

Merged
seveibar merged 5 commits intotscircuit:mainfrom
AnasSarkiz:main
Mar 25, 2026
Merged

Migrate FixedTopologyHighDensityIntraNodeSolver to fixed-via-hypergraph-solver#711
seveibar merged 5 commits intotscircuit:mainfrom
AnasSarkiz:main

Conversation

@AnasSarkiz
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Mar 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
capacity-node-autorouter Error Error Mar 25, 2026 9:31am

Request Review

@tscircuitbot
Copy link

🏃 Benchmark This PR

Run benchmarks by commenting on this PR:

/benchmark [benchmark.sh args...]
/benchmark [solver-name|all] [scenario-limit] --concurrency <n> --effort <n> --dataset <dataset01|zdwiel|srj05>

Everything after /benchmark is forwarded directly to ./benchmark.sh.

Examples:

  • /benchmark -> AutoroutingPipelineSolver4, all scenarios (default concurrency uses the benchmark runner CPU count)
  • /benchmark AutoroutingPipelineSolver4 -> one solver, all scenarios
  • /benchmark all 20 -> all solvers, first 20 scenarios
  • /benchmark AutoroutingPipelineSolver4 20 --concurrency 8 -> one solver, 20 scenarios, 8 workers
  • /benchmark AutoroutingPipelineSolver4 20 --effort 2 -> one solver, 20 scenarios, 2x effort
  • /benchmark AutoroutingPipelineSolver4 --dataset zdwiel -> one solver, all scenarios, zdwiel dataset
  • /benchmark AutoroutingPipelineSolver4 --dataset srj05 -> one solver, all scenarios, srj05 dataset
  • /benchmark all 20 --dataset dataset01 --concurrency 8 -> all solvers, 20 scenarios, dataset01, 8 workers
  • /benchmark --pipeline 4 -> same as ./benchmark.sh --pipeline 4

Any PR whose title contains [BENCHMARK TEST] will automatically run the benchmark workflow on PR updates.

@AnasSarkiz
Copy link
Member Author

/benchmark

@tscircuitbot
Copy link

tscircuitbot commented Mar 25, 2026

🏃 Autorouting Benchmark Results

📊 Main Branch Results
Benchmark Results (1x effort)

+----------------------------+-------------+--------------------+-----------+----------+----------+
| Solver                     | Completed % | Relaxed DRC Pass % | Timed Out | P50 Time | P95 Time |
+----------------------------+-------------+--------------------+-----------+----------+----------+
| AutoroutingPipelineSolver4 | 93.3%       | 23.8%              | 0/105     | 7.5s     | 44.5s    |
+----------------------------+-------------+--------------------+-----------+----------+----------+

Dataset: dataset01
Scenarios: 105
📊 PR Results
Benchmark Results (1x effort)

+----------------------------+-------------+--------------------+-----------+----------+----------+
| Solver                     | Completed % | Relaxed DRC Pass % | Timed Out | P50 Time | P95 Time |
+----------------------------+-------------+--------------------+-----------+----------+----------+
| AutoroutingPipelineSolver4 | 93.3%       | 23.8%              | 0/105     | 4.5s     | 35.3s    |
+----------------------------+-------------+--------------------+-----------+----------+----------+

Dataset: dataset01
Scenarios: 105

📦 Artifact: https://github.com/tscircuit/tscircuit-autorouter/actions/runs/23527785929

@AnasSarkiz
Copy link
Member Author

/benchmark

@tscircuitbot
Copy link

tscircuitbot commented Mar 25, 2026

🏃 Autorouting Benchmark Results

📊 Main Branch Results
Benchmark Results (1x effort)

+----------------------------+-------------+--------------------+-----------+----------+----------+
| Solver                     | Completed % | Relaxed DRC Pass % | Timed Out | P50 Time | P95 Time |
+----------------------------+-------------+--------------------+-----------+----------+----------+
| AutoroutingPipelineSolver4 | 93.3%       | 23.8%              | 0/105     | 7.5s     | 44.5s    |
+----------------------------+-------------+--------------------+-----------+----------+----------+

Dataset: dataset01
Scenarios: 105
📊 PR Results
Benchmark Results (1x effort)

+----------------------------+-------------+--------------------+-----------+----------+----------+
| Solver                     | Completed % | Relaxed DRC Pass % | Timed Out | P50 Time | P95 Time |
+----------------------------+-------------+--------------------+-----------+----------+----------+
| AutoroutingPipelineSolver4 | 93.3%       | 23.8%              | 0/105     | 4.6s     | 34.6s    |
+----------------------------+-------------+--------------------+-----------+----------+----------+

Dataset: dataset01
Scenarios: 105

📦 Artifact: https://github.com/tscircuit/tscircuit-autorouter/actions/runs/23528079400

@AnasSarkiz
Copy link
Member Author

/benchmark

@tscircuitbot
Copy link

tscircuitbot commented Mar 25, 2026

🏃 Autorouting Benchmark Results

📊 Main Branch Results
Benchmark Results (1x effort)

+----------------------------+-------------+--------------------+-----------+----------+----------+
| Solver                     | Completed % | Relaxed DRC Pass % | Timed Out | P50 Time | P95 Time |
+----------------------------+-------------+--------------------+-----------+----------+----------+
| AutoroutingPipelineSolver4 | 93.3%       | 23.8%              | 0/105     | 7.5s     | 44.5s    |
+----------------------------+-------------+--------------------+-----------+----------+----------+

Dataset: dataset01
Scenarios: 105
📊 PR Results
Benchmark Results (1x effort)

+----------------------------+-------------+--------------------+-----------+----------+----------+
| Solver                     | Completed % | Relaxed DRC Pass % | Timed Out | P50 Time | P95 Time |
+----------------------------+-------------+--------------------+-----------+----------+----------+
| AutoroutingPipelineSolver4 | 93.3%       | 23.8%              | 0/105     | 4.5s     | 35.3s    |
+----------------------------+-------------+--------------------+-----------+----------+----------+

Dataset: dataset01
Scenarios: 105

📦 Artifact: https://github.com/tscircuit/tscircuit-autorouter/actions/runs/23540231030

FixedViaHypergraphSolver,
createConvexViaGraphFromXYConnections,
} from "@tscircuit/hypergraph"
} from "@tscircuit/fixed-via-hypergraph-solver/lib/index"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to set "main" and/or "exports" within your module to avoid needing to import from lib/index

Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title is fine but can you also explain the reason for the speedup?

@seveibar seveibar merged commit 66cf7f3 into tscircuit:main Mar 25, 2026
11 of 12 checks passed
@tscircuitbot
Copy link


Thank you for your contribution! 🎉

PR Rating: ⭐⭐⭐
Impact: Major

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants