-
-
Notifications
You must be signed in to change notification settings - Fork 70
Verbose API results #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
smartclash
wants to merge
50
commits into
tsdjs:main
Choose a base branch
from
MLH-Fellowship:feature/verbose-reporting
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 34 commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
0122488
Remove VSCode config folder and add source code generation in TS build
e706b63
Allow passing of path to type definiton file manually
43ac091
Update README.md
1282ce6
Refactor code to check definition file existence if specified manually
8185162
Fix the checking of type file existence
35063ce
Use expect error instead of ignoring it
4d23908
Allow specifing test files manually
c7e427b
Allow passing relative path of typing def file
4cf8cb4
Allow passing relative path to test files
1bf9d15
Counts number of tests. Still needs to pass it.
544c401
[WIP] Verbose mode
039d8e9
Remove verbose mode option
8a9c90e
Support for ExtendedDiagnostics
ea3961a
Make changes according to suggestions
2f7e26a
Merge branch 'relative-paths' into feature/verbose-reporting
134b88c
Fixed README alignment
a447c7d
Remove counting custom rules as a test
da0741a
Provide docs for new changes
a477f69
Merge branch 'relative-paths' into feature/verbose-reporting
64409b3
Add tests for new typingsFile option
6d24bca
Fixed tests file resolving issue when typingsFile option is set
1d391ae
Add tests for testFiles option
d925296
Add tests to check cases where typings file is not found in specified…
414e242
Merge branch 'relative-paths' into feature/verbose-reporting
59670d6
Use globby for testFiles option
eb4a6ea
Merge branch 'relative-paths' into feature/verbose-reporting
9eb0912
Add unit test to check numTests parameter
SaurabhAgarwala 41e9e0c
Remove .vscode entry in gitignore
smartclash 02927f0
Update docs
smartclash 285c6cb
Make testFiles property readonly
smartclash 59c5f4b
Fix grammar
smartclash d27c0df
Merge branch 'relative-paths' into feature/verbose-reporting
smartclash 641e5cd
Grammar and typo fix
smartclash caf42f2
Merge branch 'feature/verbose-reporting' of github.com:MLH-Fellowship…
smartclash 9ece40e
Grammar in README
smartclash 7b8d323
Merge branch 'relative-paths' into feature/verbose-reporting
smartclash 44c066e
Update readme.md
c549587
Improve readme
smartclash cb3da21
Merge branch 'relative-paths' into feature/verbose-reporting
smartclash 9424f46
Refactor numTests into testCount
smartclash 473f255
Counts number of tests. Still needs to pass it.
796568e
[WIP] Verbose mode
015277e
Remove verbose mode option
67662cd
Support for ExtendedDiagnostics
d8e7301
Remove counting custom rules as a test
6e7c49c
Provide docs for new changes
101eb4f
Grammar and typo fix
smartclash de2b549
Add unit test to check numTests parameter
SaurabhAgarwala f6e579a
Refactor numTests into testCount
smartclash 1be32cf
Merge remote-tracking branch 'origin/feature/verbose-reporting' into …
smartclash File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| declare const one: { | ||
| (foo: string, bar: string): string; | ||
| (foo: number, bar: number): number; | ||
| }; | ||
|
|
||
| export default one; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| module.exports.default = (foo, bar) => { | ||
| return foo + bar; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "name": "foo" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| import {expectType} from '../../..'; | ||
| import one from '.'; | ||
|
|
||
| expectType<string>(one('foo', 'bar')); | ||
| expectType<string>(one(1, 2)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| module.exports.default = (foo, bar) => { | ||
| return foo + bar; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| import {expectType} from '../../..'; | ||
| import one from './utils'; | ||
|
|
||
| expectType<string>(one('foo', 'bar')); | ||
| expectType<string>(one(1, 2)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "name": "foo" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| declare const one: { | ||
| (foo: string, bar: string): string; | ||
| (foo: number, bar: number): number; | ||
| }; | ||
|
|
||
| export default one; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you like the
numTeststo be renamed intotestCount?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've refactored all instances of
numTestsintotestCount.