fix(cli): Normalize boolean flags before parsing - #763
Open
reneleonhardt wants to merge 1 commit into
Open
Conversation
Co-Authored-By: GPT-5.6 Sol <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Legacy boolean syntax (-keepalive false) could be interpreted as a positional argument, causing inconsistent parsing and keepalive behavior.
Positional parsing consumed
-keepaliveand treatedfalseas an argument, so later flags were ignored and text consumers could fail on binary stdout ('utf-8' codec can't decode byte 0xff in position 0).What
Reproduction
go run . attack -keepalive false -http2 false -duration 1s -rate 1 -output /tmp/vegeta-results.binVerification
go test ./...go test ./... -run '^(TestNormalizeBooleanFlagArgs|TestNormalizeBooleanFlagArgsForUnknownFlags|TestAttackCmdLegacyBooleanStyleUsesNormalizedBooleanParsing|TestAttackCmdAttachedBooleanStyleUsesNormalizedBooleanParsing|TestMainVersionPrintsBuildMetadata)$'Checklist
Developed with carefully directed, manually reviewed AI assistance.
Co-Authored-By: GPT-5.6 Sol codex@openai.com