[map-guessr] Support #tsgbot-games channel via ChannelLimitedBot by Copilot · Pull Request #1165 · tsg-ut/slackbot

Copilot · 2026-03-01T17:17:21Z

Refactor map-guessr/index.ts to use ChannelLimitedBot from lib/channelLimitedBot.ts
Use shorthand property notation throughout (channel, zoom, size instead of channel: channel, etc.)
Type world as Turf.FeatureCollection<Turf.MultiPolygon> in class property, constructor, and prepareProblem parameter
TypeScript compiles without errors

Original prompt

This section details on the original issue you should resolve

<issue_title>[map-guessr] #tsgbot-games 対応 & ChannelLimitedBotクラスを導入</issue_title>
<issue_description>Issue #1099 の対応の一環として、 map-guessr BOTの改修を行う。

Slackの #tsgbot-games チャンネルからの起動に対応できるようにする。また、 lib/channelLimitedBot.ts で定義されたChannelLimitedBotクラスを利用し、起動チャンネルの指定と進行中のゲームの通知を導入する。

改修にあたっては、すでに行われた以下の3つのBOTの同様の修正の修正内容を必ず参照し、これらのスタイルを可能な限り踏襲する。

なお、対象のBOTがJavaScriptで書かれている場合は、今回の改修でTypeScriptに書き換える必要はない。このプロジェクトではJavaScriptとTypeScriptを混在させることができる。また、そのほか改修に関係ない改良を加える必要はない。

anime bot

Pull Request: Refactor anime bot to use ChannelLimitedBot for #tsgbot-games support #1138

diff: https://github.com/tsg-ut/slackbot/pull/1138.diff

Main file: anime/index.js

character-quiz bot

Pull Request: character-quiz: ChannelLimetedBotクラスを使用するよう修正 #1122

diff: https://github.com/tsg-ut/slackbot/pull/1122.diff

Main file: character-quiz/index.ts

achievement-quiz bot

Pull Request: Refactor achievement-quiz to use ChannelLimitedBot for #tsgbot-games support #1124

diff: https://github.com/tsg-ut/slackbot/pull/1124.diff

Main file: achievement-quiz/index.ts</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes [map-guessr] #tsgbot-games 対応 & ChannelLimitedBotクラスを導入 #1164

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…support Co-authored-by: hakatashi <[email protected]>

hakatashi · 2026-03-03T02:35:24Z

  const problem: CoordAteQuizProblem = {
    problemMessage: {
-      channel: CHANNEL,
+      channel: channel,


@copilot 省略記法を使用してください。他の部分も同様です

Suggested change

channel: channel,

channel,

Fixed in 59035a6 — replaced all channel: channel, zoom: zoom, and size: size with their shorthand equivalents throughout the file.

hakatashi · 2026-03-03T02:38:50Z

-      await slack.chat.postMessage({
+  private readonly aliases: Record<string, string[]>;
+
+  private readonly world: any;


@copilot 他の部分から推測して world 変数も型付けしてください

Fixed in 59035a6 — typed world as Turf.FeatureCollection<Turf.MultiPolygon> (verified via countries.geojson which contains only MultiPolygon features). Updated the class property, constructor parameter, and prepareProblem parameter accordingly.

Co-authored-by: hakatashi <[email protected]>

hakatashi

tsg-ut-gemini-assistant · 2026-03-03T05:00:08Z

えへ～

ありがとう！

レビューさせてもらうにゃ！

🔍️🔍️🔍️️

tsg-ut-gemini-assistant

📋 Review Summary

map-guessr を ChannelLimitedBot を使うようにリファクタリングしてくれてありがとにゃ！全体的にいい感じだと思うにゃ。今後のメンテナンスもしやすくなったんじゃないかにゃ？

🔍 General Feedback

型定義をしっかりやっててえらいにゃ！ world の型を any からちゃんと設定してるのは、とっても良いことだにゃ！
クラスベースに書き直したことで、コードがすっきりして見やすくなったと思うにゃ。にゃししっ！

sonarqubecloud · 2026-03-03T05:03:21Z

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copilot

Pull request overview

Refactors the map-guessr bot to use the shared ChannelLimitedBot infrastructure so it can run in the designated games channel and participate in “ongoing game” progress notifications.

Changes:

Migrates map-guessr/index.ts from manual eventClient.on("message") handling to a ChannelLimitedBot subclass with onWakeWord.
Threads channel through quiz message construction (problemFormat / prepareProblem) and applies shorthand property notation.
Tightens typing of world as Turf.FeatureCollection<Turf.MultiPolygon>.

Copilot · 2026-03-03T05:04:40Z

+    if (message.text.includes('help')) {
+      this.postMessage({
        ...mesHelp,
-        ...postOptions,
-        ...messageTs,
+        channel,
+        thread_ts: message.ts,
      });


onWakeWord posts help output as a threaded reply using thread_ts: message.ts. When ChannelLimitedBot redirects execution to another channel, message.ts belongs to the original channel, so posting with that thread_ts will fail (invalid thread in the target channel). Consider posting help as a normal message in channel (no thread_ts), and return that posted message ts so callers from disallowed channels can be redirected to the right place.

Copilot · 2026-03-03T05:04:41Z

+          message,
+          this.aliases,
+          this.world,
+          message.ts,


Same cross-channel threading issue exists when starting a quiz: prepareProblem is given thread_ts: message.ts, but if the bot is invoked from a non-allowed channel, that ts does not exist in the redirected channel and Slack API calls that rely on it will fail. A more robust pattern is to first post a root message in the target channel (or let AteQuiz post the root without thread_ts) and then use the returned ts as the thread root for the rest of the quiz; return that ts from onWakeWord for ChannelLimitedBot progress-linking.

Suggested change

message.ts,

channel === message.channel ? message.ts : undefined,

Copilot · 2026-03-03T05:04:41Z

        text: "`座標当て countries`あるいは `座標あて countries`と入力すると、対応している国・地域の一覧が見られます。",
      },
    },
  ],
-  channel: CHANNEL,
 };


mesHelp content still tells users to run the command in the sandbox channel, but this bot now relies on ChannelLimitedBot (default allowedChannels is CHANNEL_GAMES). Please update the help text to match the actual supported/allowed channel(s) so users aren’t misled.

Copilot · 2026-03-03T05:04:41Z

@@ -5,16 +5,18 @@
 import { AteQuizProblem, AteQuizResult } from "../atequiz";


Unused import: AteQuizResult is imported but never referenced in this file. Please remove it to keep imports clean and avoid confusing readers about expected return types.

Suggested change

import { AteQuizProblem, AteQuizResult } from "../atequiz";

import { AteQuizProblem } from "../atequiz";

PolinaBalanyeva

LGTM

Initial plan

c5797ed

Copilot AI assigned Copilot and hakatashi Mar 1, 2026

Copilot started work on behalf of hakatashi March 1, 2026 17:17 View session

feat: refactor map-guessr to use ChannelLimitedBot for #tsgbot-games …

616443f

…support Co-authored-by: hakatashi <[email protected]>

Copilot AI changed the title ~~[WIP] Add support for #tsgbot-games channel in map-guessr bot~~ [map-guessr] Support #tsgbot-games channel via ChannelLimitedBot Mar 1, 2026

Copilot finished work on behalf of hakatashi March 1, 2026 17:28

hakatashi reviewed Mar 3, 2026

View reviewed changes

Copilot started work on behalf of hakatashi March 3, 2026 02:39 View session

Copilot AI and others added 2 commits March 3, 2026 02:43

fix: use shorthand property notation and type world as FeatureCollection

59035a6

Co-authored-by: hakatashi <[email protected]>

fix: update message handling to check for bot_id instead of subtype

80bc765

Copilot finished work on behalf of hakatashi March 3, 2026 02:44

hakatashi requested a review from PolinaBalanyeva March 3, 2026 03:57

hakatashi approved these changes Mar 3, 2026

View reviewed changes

hakatashi marked this pull request as ready for review March 3, 2026 04:59

Copilot AI review requested due to automatic review settings March 3, 2026 04:59

Copilot started reviewing on behalf of hakatashi March 3, 2026 05:00 View session

tsg-ut-gemini-assistant bot reviewed Mar 3, 2026

View reviewed changes

Comment thread map-guessr/index.ts

hakatashi requested a review from settyan117 as a code owner March 3, 2026 05:02

hakatashi enabled auto-merge March 3, 2026 05:04

Copilot AI reviewed Mar 3, 2026

View reviewed changes

PolinaBalanyeva approved these changes Mar 14, 2026

View reviewed changes

	message.ts,
	channel === message.channel ? message.ts : undefined,

		@@ -5,16 +5,18 @@
		import { AteQuizProblem, AteQuizResult } from "../atequiz";

	import { AteQuizProblem, AteQuizResult } from "../atequiz";
	import { AteQuizProblem } from "../atequiz";

Conversation

Copilot AI commented Mar 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

anime bot

character-quiz bot

achievement-quiz bot

Comments on the Issue (you are @copilot in this section)

Uh oh!

hakatashi Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

hakatashi Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

hakatashi left a comment

Choose a reason for hiding this comment

Uh oh!

tsg-ut-gemini-assistant bot commented Mar 3, 2026

Uh oh!

tsg-ut-gemini-assistant bot left a comment

Choose a reason for hiding this comment

📋 Review Summary

🔍 General Feedback

Uh oh!

Uh oh!

sonarqubecloud bot commented Mar 3, 2026

Quality Gate passed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

PolinaBalanyeva left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Mar 1, 2026 •

edited

Loading