Changed header value separator to match default used by .NET System.Net.Http#42
Open
jimp100 wants to merge 1 commit intotsibelman:masterfrom
Open
Changed header value separator to match default used by .NET System.Net.Http#42jimp100 wants to merge 1 commit intotsibelman:masterfrom
jimp100 wants to merge 1 commit intotsibelman:masterfrom
Conversation
…standard The header value default separator used by `System.Net.Http` is ", " - a comma and a space. The header signing process needs to match this otherwise the signature not match the headers as sent over the wire by `System.Net.Http` Microsoft's decision can be seen in the .NET source code: https://github.com/dotnet/runtime/blob/9d4c65ddddb340cdb1479cafc6e320d1918c82eb/src/libraries/System.Net.Http/src/System/Net/Http/Headers/HttpHeaderParser.cs#L13C9-L13C53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header value default separator used by
System.Net.Httpis", "- a comma followed by a space.The signing process needs to match this otherwise the signature will not match the headers as sent over the wire by
System.Net.HttpMicrosoft's decision can be seen in the .NET source code: HttpHeaderParser.cs