Color trace lines by diagnostic thresholds#82
Open
wndzph9jkb-create wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #40.
This adds diagnostic-threshold coloring to the trace tree UI:
traceTimeThresholdstraceTypeThresholdstraceTotalTypeThresholdstraceTimeThresholdsNotes
Severity is annotated before sending trace data to the webview, as suggested in the issue. The shared message schema now includes the severity fields so they are preserved during Zod parsing on the UI side.
I also fixed the trace tree duration display so the microsecond-to-ms conversion happens before rounding.
A regression test covers
showTreemessage parsing so severity fields do not get stripped from tree nodes or type rows.Verification
corepack pnpm exec vitest runcorepack pnpm typecheckcorepack pnpm lintcorepack pnpm run generate:contributescd srcDev && corepack pnpm exec rollup -ccorepack pnpm exec nuxt build uicorepack pnpm exec rollup -c