fix(odyssee): fix leftover issues with odyssee heatpumps#77
Merged
Conversation
Owner
Author
|
@FSlunkk Finally I've been able to spend some time into debugging. I hope I addressed the issue you mentioned in this branch. Let's discuss and fix any open issues left with the odyssee protocol here. |
|
@tspopp I'm sorry but there is not change. |
Owner
Author
|
MITM or Listener? |
|
MITM |
Owner
Author
|
Sorry, now I spotted the actual issue. While reading from the correct byte position for operation mode and type, I was writing to the wrong byte position. Now it should work as expected. |
|
@tspopp Thanks, it works! |
Owner
Author
|
Nice 🎉. I keep this open for a while and wait if there is more feedback/issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proceeding from #69
issues: