UI #1055
Open
UI #1055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f5f990a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates multiple UI demos by revising component usage, updating design tokens and styling, and removing deprecated components. Key changes include:
- Replacing old color and style patterns with updated design tokens (e.g. using oklch colors and new CSS variables).
- Refactoring components such as Command, Combobox, and Calendar to use updated UI kit patterns.
- Removing deprecated demos (Callout, BlurFade, BlurImage) and updating documentation accordingly.
Reviewed Changes
Copilot reviewed 195 out of 197 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| apps/docs/src/components/demos/drawer/drawer.tsx | Updated fill color for demo graphics using a new CSS variable. |
| apps/docs/src/components/demos/command/command.tsx | Replaced legacy keyboard shortcut elements with CommandShortcut. |
| apps/docs/src/components/demos/combobox/combobox.tsx | Replaced combobox with a Popover/Command pattern and refactored state handling. |
| apps/docs/src/components/demos/chart/chart.tsx | Introduced a new area chart demo and updated chart configuration. |
| apps/docs/src/components/demos/callout/(warning, error, callout) | Removed Callout demos. |
| apps/docs/src/components/demos/calendar/(range, calendar).tsx | Added new Calendar demos with range and single selection modes. |
| apps/docs/src/components/demos/button/(pending, icon).tsx | Updated button demos to include a loader icon and simplified icon usage. |
| apps/docs/src/components/demos/blur-image/blur-image.tsx | Removed BlurImage demo. |
| apps/docs/src/components/demos/blur-fade/blur-fade.tsx | Removed BlurFade demo. |
| apps/docs/src/components/demos/aspect-ratio/aspect-ratio.tsx | Updated image source and alt text for improved clarity. |
| apps/docs/src/components/demos/alert/(destructive, alert).tsx | Added new Alert demos with distinct styling for success and error. |
| apps/docs/src/app/(main)/[[...slug]]/page.tsx | Updated conditional rendering for link badges. |
| apps/docs/src/app/(main)/[[...slug]]/link-badges.tsx | Refactored LinkBadges to use simplified conditional rendering. |
Files not reviewed (2)
- .cspell.json: Language not supported
- apps/docs/package.json: Language not supported
Comments suppressed due to low confidence (1)
apps/docs/src/components/demos/drawer/drawer.tsx:112
- Replacing 'hsl(var(--foreground))' with 'var(--primary)' may affect accessibility if the contrast is altered. Verify that this change maintains sufficient visual contrast according to the design guidelines.
fill: 'var(--primary)',
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cvabeta? <component /> : nullto&& <component />oklabandoklchto known word list.Chart,Calendar<Callout />with<Alert /><VisuallyHidden />withsr-only<BlurFade />and<BlurImage />size-4classes.<Progress />which is using@ark-ui/react<Slider />which is using@ark-ui/react<Combobox />which is using@ark-ui/react<CommandFooter />toastertosonnergetAvatarAbbreviation()togetAbbreviation()