handle more flexible patterns

[ttutisani]

No description provided.

[ttutisani]

@miguelius I reviewed and I have some questions. Please respond and I will think more about this.

[ttutisani]

This does not belong here conceptually. This is a feature file repository not a file path repository. What are you trying to do with it?

[ttutisani]

Isn't this what you are trying to fix? MatchesFilePathPattern - this returns false but must return true. Am I missing something?

[ttutisani]

What happens if the path contains multiple asterisk symbols such as in the folder names? e.g., ./Features*Test/*.feature. Will this work fine? I think this will have a problem, correct? I am asking before this PR is merged, will it work? This PR will not be able to address such use case for sure.

[miguelius]

Good point! I think that no Directory API method can handle that pattern. I'll try it!

[miguelius]

Tried it with dotnet-script and I get:

> Directory.EnumerateFiles(".","Desc*/*.doc")
System.IO.DirectoryNotFoundException: System.IO.DirectoryNotFoundException: Could not find a part of the path '/home/u86415/Desc*'.
  + FileSystemEnumerator<TResult>.CreateDirectoryHandle(string, bool)
  + FileSystemEnumerator<TResult>.Init()
  + FileSystemEnumerator<TResult>..ctor(string, bool, System.IO.EnumerationOptions)
  + FileSystemEnumerable<TResult>..ctor(string, System.IO.Enumeration.FileSystemEnumerable<TResult>.FindTransform, System.IO.EnumerationOptions, bool)
  + System.IO.Enumeration.FileSystemEnumerableFactory.UserFiles(string, string, System.IO.EnumerationOptions)
  + System.IO.Directory.InternalEnumeratePaths(string, string, System.IO.SearchTarget, System.IO.EnumerationOptions)
  + System.IO.Directory.EnumerateFiles(string, string)
> Directory.GetFiles(".","Desc*/*.doc")
System.IO.DirectoryNotFoundException: System.IO.DirectoryNotFoundException: Could not find a part of the path '/home/u86415/Desc*'.
  + FileSystemEnumerator<TResult>.CreateDirectoryHandle(string, bool)
  + FileSystemEnumerator<TResult>.Init()
  + FileSystemEnumerator<TResult>..ctor(string, bool, System.IO.EnumerationOptions)
  + FileSystemEnumerable<TResult>..ctor(string, System.IO.Enumeration.FileSystemEnumerable<TResult>.FindTransform, System.IO.EnumerationOptions, bool)
  + System.IO.Enumeration.FileSystemEnumerableFactory.UserFiles(string, string, System.IO.EnumerationOptions)
  + System.IO.Directory.InternalEnumeratePaths(string, string, System.IO.SearchTarget, System.IO.EnumerationOptions)
  + System.IO.Directory.GetFiles(string, string, System.IO.EnumerationOptions)
  + System.IO.Directory.GetFiles(string, string)

It looks like it doesn't support wildcards but in the file name. Basically like dir command.

[ttutisani]

Okay, thanks for trying it! Is that based on my master branch or your fork?