Skip to content

Conversation

@Joschi3
Copy link
Member

@Joschi3 Joschi3 commented Oct 21, 2025

If a mimicked joint is controlled by the hardware interface, the state of the mimic joint is added to the state interface.

@Joschi3 Joschi3 self-assigned this Oct 21, 2025
@Joschi3 Joschi3 requested a review from Copilot October 21, 2025 19:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds state interface support for mimic joints in the Dynamixel hardware interface. When a mimicked joint is controlled by the hardware interface, the state of the mimic joint is now properly exposed through state interfaces, allowing controllers to access mimic joint states.

Key changes:

  • Added MimicState struct to track mimic joint state values (position, velocity, effort) along with offset and multiplier
  • Implemented setupMimicJoint() and updateMimicJointStates() methods to initialize and update mimic joint states
  • Modified hardware interface initialization and read cycle to create state interfaces for mimic joints and update their values

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
dynamixel_ros_control/include/dynamixel_ros_control/joint.hpp Defines MimicState struct and declares mimic joint setup/update methods
dynamixel_ros_control/src/joint.cpp Implements mimic joint initialization and state update logic with position/velocity/effort calculations
dynamixel_ros_control/src/dynamixel_hardware_interface.cpp Integrates mimic joint setup during initialization, creates state interfaces, and triggers state updates during read cycle

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Joschi3 Joschi3 requested a review from Copilot October 21, 2025 19:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Joschi3 Joschi3 merged commit 719089b into jazzy Oct 22, 2025
3 checks passed
@Joschi3 Joschi3 deleted the feature/mimic_joints branch October 22, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants