-
Notifications
You must be signed in to change notification settings - Fork 0
Add State Interfaces for mimic joints #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds state interface support for mimic joints in the Dynamixel hardware interface. When a mimicked joint is controlled by the hardware interface, the state of the mimic joint is now properly exposed through state interfaces, allowing controllers to access mimic joint states.
Key changes:
- Added
MimicStatestruct to track mimic joint state values (position, velocity, effort) along with offset and multiplier - Implemented
setupMimicJoint()andupdateMimicJointStates()methods to initialize and update mimic joint states - Modified hardware interface initialization and read cycle to create state interfaces for mimic joints and update their values
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| dynamixel_ros_control/include/dynamixel_ros_control/joint.hpp | Defines MimicState struct and declares mimic joint setup/update methods |
| dynamixel_ros_control/src/joint.cpp | Implements mimic joint initialization and state update logic with position/velocity/effort calculations |
| dynamixel_ros_control/src/dynamixel_hardware_interface.cpp | Integrates mimic joint setup during initialization, creates state interfaces, and triggers state updates during read cycle |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
If a mimicked joint is controlled by the hardware interface, the state of the mimic joint is added to the state interface.