Skip to content

Conversation

@Joschi3
Copy link
Member

@Joschi3 Joschi3 commented Oct 21, 2025

Allows updating the LED color of all connected dynamixel servos with just a single write instruction.

@Joschi3 Joschi3 self-assigned this Oct 21, 2025
@Joschi3 Joschi3 requested a review from Copilot October 21, 2025 19:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a centralized LED write manager to efficiently update LED colors across all connected Dynamixel servos using a single synchronized write instruction, replacing the previous approach of individual write operations per servo.

Key changes:

  • Introduced LED_State struct to track LED color values (red, green, blue) for each joint
  • Added setUpLEDWriteManager() to initialize synchronized LED writing across all servos
  • Refactored setColorLED() to use batch write operations instead of individual register writes

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
dynamixel_hardware_interface.cpp Implements LED write manager setup and refactors setColorLED() to use synchronized writes
joint.hpp Adds LED_State struct to store per-joint LED color values
dynamixel_hardware_interface.hpp Declares LED write manager member and setup function

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@tu-darmstadt-ros-pkg tu-darmstadt-ros-pkg deleted a comment from Copilot AI Oct 21, 2025
@tu-darmstadt-ros-pkg tu-darmstadt-ros-pkg deleted a comment from Copilot AI Oct 21, 2025
@Joschi3 Joschi3 force-pushed the feature/led_write_manager branch from e0605c7 to d461fc4 Compare October 22, 2025 08:18
@Joschi3 Joschi3 merged commit a671902 into jazzy Oct 22, 2025
3 checks passed
@Joschi3 Joschi3 deleted the feature/led_write_manager branch October 22, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants