Add python pkg with cmake build #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Excelsius314
force-pushed
the
feature/python-cmake-template
branch
from
3d874da to
00bb906
Compare
Joschi3
requested changes
Aug 21, 2025
ros2_pkg_create/create_pkg.py
Outdated
| parser.add_argument("--use-local-templates", action="store_true", help="Use locally installed templates instead of remotely pulling most recent ones") | ||
|
|
||
| # parser.add_argument("--template", type=str, default=None, choices=["cpp_pkg", "msgs_pkg", "python_pkg", "ci"], required=True, help="Template") | ||
| parser.add_argument("--template", type=str, default=None, choices=["cpp_pkg", "msgs_pkg", "python_pkg", "ci"], required=True, help="Template") |
There was a problem hiding this comment.
Why did you uncomment this? In any case, your package type is missing in the choices list
|
|
||
| | Parameter | Type | Description | | ||
| | --- | --- | --- | | ||
| | | | | |
There was a problem hiding this comment.
Maybe add a general section here on how the venv creation and update work.
…rg to build venv isolated from system-packages
…cess for launch test alive
… otherwise empty templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add python cmake package template with support for the creation of a virtual environment