Add a wtf script to check if any packages are mistaken as catkin package. #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joschi3
requested changes
Aug 11, 2025
Member
Joschi3
left a comment
Joschi3
left a comment
There was a problem hiding this comment.
Overall looks good. Minor suggestion to update the description for hooks to also include Python scripts that return two integers (encountered problems vs fixed problems).
| print_workspace_error() | ||
| return 1 | ||
|
|
||
| count_problems = 0 |
Member
There was a problem hiding this comment.
Update the description above to include Python scripts that return two ints (encountered problems vs fixed problems.
Member
Author
There was a problem hiding this comment.
Good point. Updated the description and also improved readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes through all packages, checks if colcon thinks they are catkin packages.
If it does, it checks the
buildtool_dependtags in the package.xml.If they say
ament_cmake, this is probably mistakenly identified as such because the package.xml is missing theexportdeclaration.