Skip to content

refactor(secret): remove in-process secret resolver, document piping#189

Merged
tuannvm merged 1 commit into
mainfrom
worktree-piping-secret
Apr 16, 2026
Merged

refactor(secret): remove in-process secret resolver, document piping#189
tuannvm merged 1 commit into
mainfrom
worktree-piping-secret

Conversation

@tuannvm
Copy link
Copy Markdown
Owner

@tuannvm tuannvm commented Apr 16, 2026

Delete internal/secret/ (Vault, 1Password, command providers) and have config read directly from the process environment. Users inject secrets via external tools (op run, vault agent, K8s Secret + envFrom) — smaller attack surface, no app-side backend clients.

Add docs/secrets.md covering 1Password, Vault, K8s patterns plus security nuances (shell history, ps leakage, leak testing).

Summary

Changes

Testing

  • Tests pass locally
  • New tests added (if applicable)

Related Issues

Delete internal/secret/ (Vault, 1Password, command providers) and have
config read directly from the process environment. Users inject secrets
via external tools (op run, vault agent, K8s Secret + envFrom) — smaller
attack surface, no app-side backend clients.

Add docs/secrets.md covering 1Password, Vault, K8s patterns plus
security nuances (shell history, ps leakage, leak testing).

Co-authored-by: Claude <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 16, 2026

Warning

Rate limit exceeded

@tuannvm has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 37 minutes and 4 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 37 minutes and 4 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ab91b480-2e79-45eb-bd01-dabc00faef2c

📥 Commits

Reviewing files that changed from the base of the PR and between adf7984 and 3e39488.

📒 Files selected for processing (14)
  • .gitignore
  • README.md
  • docs/secrets.md
  • internal/config/config.go
  • internal/config/config_test.go
  • internal/secret/command.go
  • internal/secret/command_test.go
  • internal/secret/convert.go
  • internal/secret/onepassword.go
  • internal/secret/onepassword_test.go
  • internal/secret/resolver.go
  • internal/secret/resolver_test.go
  • internal/secret/vault.go
  • internal/secret/vault_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch worktree-piping-secret

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tuannvm tuannvm merged commit 3e0be00 into main Apr 16, 2026
4 of 5 checks passed
@tuannvm tuannvm deleted the worktree-piping-secret branch April 16, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant