Prevent unquoted font family names that match color names from being …#50
Open
zytzagoo wants to merge 3 commits intotubalmartin:masterfrom
Open
Prevent unquoted font family names that match color names from being …#50zytzagoo wants to merge 3 commits intotubalmartin:masterfrom
zytzagoo wants to merge 3 commits intotubalmartin:masterfrom
Conversation
can probably be improved further...
Owner
|
Thank you very much for the PR, looks good. I'll work on this in a few days :) |
|
@tubalmartin hey! Is this PR still going to get merged? Asking, since I want to use this fix as part of the composer package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…replaced
Fixes #48 in a relatively crude fashion, but other attempts at fixing it quickly only resulted in breaking some other existing test cases.
A test is in there too now to cover the expected behaviour.