Open
Conversation
Two issues addressed: 1. StreamElement.templateContent clones template content via cloneNode(true), but browsers hide nonce attribute values after HTML parsing (Chrome security feature). The cloned scripts have nonce="" and get blocked by CSP's script-src-elem directive. Fix: activate scripts in the cloned content using activateScriptElement, consistent with FrameRenderer and ErrorRenderer. 2. activateScriptElement sets the CSP nonce before copyElementAttributes, which then overwrites it with an empty string (from the source element's hidden nonce). Fix: move nonce assignment after copyElementAttributes. Fixes inline script CSP violations in Turbo Stream responses when a Content-Security-Policy with nonce-based script-src-elem is in effect. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StreamElement.templateContent clones template content via
cloneNode(true), but browsers hide nonce attribute values after HTML parsing (Chrome nonce hiding). The cloned scripts havenonce=""and get blocked by CSP'sscript-src-elemdirective. Fix: activate scripts in the cloned content usingactivateScriptElement, consistent with howFrameRendererandErrorRendereralready handle scripts.activateScriptElement sets the CSP nonce before
copyElementAttributes, which then overwrites it with an empty string (from the source element's hidden nonce). Fix: move nonce assignment aftercopyElementAttributes.Related upstream issues
activateScriptElementoverwrites CSP noncecopyElementAttributesordering fixTest plan
receiving a message with a <script> element) continues to passscript-src-elemthat inline scripts in Turbo Stream responses execute without CSP violations🤖 Generated with Claude Code