Skip to content

IMP install openmp with bazel #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pdvyas wants to merge 1 commit into
base: master
Choose a base branch
from
Open

IMP install openmp with bazel #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Formula/bazel.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ class Bazel < Formula

depends_on :java => "1.8"
depends_on :macos => :yosemite
depends_on "libomp"
Copy link
Copy Markdown

@srstrickland srstrickland Aug 14, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure this shouldn't be libgomp? https://github.com/tubular/infrastructure/blob/master/jenkins_jobs/jobs/watchtime/watchtime.yaml#L185

Copy link
Copy Markdown
Contributor

@qfliu qfliu Aug 14, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I run the test, it is throwing exception 'Library not loaded: /usr/local/opt/libomp/lib/libomp.dylib'. After manually installing it using brew and followed step here https://lightgbm.readthedocs.io/en/latest/Installation-Guide.html#macos, it worked. Not sure if we just brew install, it works or not. Maybe libgomp installs libomp? Or is there actually other part of lightgbm that depends on libgomp which the test cases do not trigger?

Copy link
Copy Markdown

@albertc1 albertc1 Aug 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be libgomp on ubuntu but libomp on osx?


def install
ENV["EMBED_LABEL"] = "#{version}-homebrew"
Expand Down