Feature/guarded motion added distance until edge up #1199
Conversation
P-ict0
force-pushed
the
feature/guarded_motion_added_distance_until_edge_up
branch
from
0b3163d to
07468c5
Compare
P-ict0
force-pushed
the
feature/guarded_motion_added_distance_until_edge_up
branch
from
07468c5 to
d399630
Compare
robot_skills/src/robot_skills/functionalities/arm/guarded_motion.py
Outdated
Show resolved
Hide resolved
robot_skills/src/robot_skills/functionalities/arm/guarded_motion.py
Outdated
Show resolved
Hide resolved
robot_skills/src/robot_skills/functionalities/arm/guarded_motion.py
Outdated
Show resolved
Hide resolved
|
|
||
| # Sets the joint state to move down a certain distance (or 0 if distance is not set) | ||
| if distance_move_down is not None: | ||
| current_joint_state['arm_lift_joint'] = max(0, current_joint_state['arm_lift_joint'] - distance_move_down) |
There was a problem hiding this comment.
0 should be the lower limit of the joint.
There was a problem hiding this comment.
0 is the lowest the arm lift joint state value can be. With the distance_move_down it can be greater than 0
robot_skills/src/robot_skills/functionalities/arm/guarded_motion.py
Outdated
Show resolved
Hide resolved
|
|
||
|
|
||
| def move_down_until_force_sensor_edge_up(self, force_sensor=None, timeout=10, retract_distance=0.01): | ||
| def move_down_until_force_sensor_edge_up(self, force_sensor=None, timeout=10, retract_distance=0.01, |
There was a problem hiding this comment.
I think the final position is more interesting than the distance to move down.
There was a problem hiding this comment.
I agree, I thought of adding the distance to move down first before working on the final position since this requires to calculate at what height the force sensor is. I think the final point is an interesting feature for me to work on in the future
PetervDooren
left a comment
PetervDooren
left a comment
There was a problem hiding this comment.
I think this is already an improvement over the previous version, although I agree with matthijs that the other functionality would be preffered in the long run.
| goal = self._create_lower_force_sensing_goal(distance_move_down, timeout) | ||
| self._ac_joint_traj.send_goal(goal) | ||
|
|
||
| force_sensor.wait_for_edge_up(timeout) |
There was a problem hiding this comment.
The behaviour we currently create will wait for the timeout if its end goal is reached. So it might be waiting at the lower position without continuing.
There was a problem hiding this comment.
I don't think this is acceptable
There was a problem hiding this comment.
Isn't this the same behaviour as before? but with a different distance to move down.
|
I suggest that we decide before continuing:
|
move_down_until_force_sensor_edge_upinguarded_motion.pyandarms.pyso that the travel distance until an edge up is customizableguarded_motion.pymove_down_until_force_sensor_edge_up