fix: handle missing region in navigator.language for chart locale#973
Merged
fix: handle missing region in navigator.language for chart locale#973
Conversation
When navigator.language is just "en" without a region suffix (e.g. "en-US"), the locale() function produced "en-undefined", an invalid language tag that crashes toLocaleDateString() and breaks chart rendering and date pickers. Use navigator.language directly instead of extracting and re-assembling the region component. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
navigator.language is supported in all modern browsers and always returns a string. The userLanguage fallback was only needed for IE. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dosubot
bot
added
size:S
pepicrft
approved these changes
Mar 4, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RangeError: Invalid language tag: en-undefinedcrash whennavigator.languagehas no region suffix (e.g."en"instead of"en-US")navigator.languagedirectly instead of extracting and re-assembling the region, which also respects the user's actual locale rather than forcingen-*Test plan
navigator.languageset to"en"(no region)navigator.languageset to"en-US"(with region)🤖 Generated with Claude Code