fix: correct SetGroupDescription to properly handle deletes and updates#851
Open
xTudoS wants to merge 2 commits into
Open
fix: correct SetGroupDescription to properly handle deletes and updates#851xTudoS wants to merge 2 commits into
xTudoS wants to merge 2 commits into
Conversation
purpshell
approved these changes
Aug 15, 2025
Contributor
purpshell
left a comment
purpshell
left a comment
There was a problem hiding this comment.
LGTM
Not sure why WhatsApp is doing this.. 🤔 Maybe it is to sequence these updates properly, and also probably just to track these changes (as always)
Author
I think its a way to deprecate old devices and unofficial apps |
purpshell
reviewed
May 11, 2026
| } | ||
|
|
||
| content := waBinary.Node{ | ||
| Tag: "description", |
Contributor
There was a problem hiding this comment.
I would look further to see if this is change that also affects topics etc. not just descriptions 👀
Author
There was a problem hiding this comment.
Are you going to try? This PR is almost 1 year old
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add missing attributes for description updates/deletions