Ask before closing #118
Open
Ask before closing #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Especially useful when submitting multiple issues in a loop
realsonic
reviewed
Nov 16, 2018
| this.TimeElapsed = TimeElapsed; | ||
| DateTimeOffset initialStartTime; | ||
| if (startTime == null) | ||
| public WorklogForm(IssueControl issueControl) |
There was a problem hiding this comment.
I don't think it's good practice to increase coupling.
There was a problem hiding this comment.
I did this to not make the already long signature of the constructor even longer. Because all the arguments only really make sense if they stem from the same IssueControl object I thought the cleaner signature makes clearer what's going on.
It's not a big deal to change that back, though – if this PR has any chance of being accepted by @carstengehling.
There was a problem hiding this comment.
Agree with you. Repository looks abandoned...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a message that asks whether to submit all tracked times before closing the program. Should work similarly to the familiar Save prompt popping up when closing modified files in editors.
Please review, I'm not experienced with C#.