Aws integration changes #23
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the AWS integration documentation to provide a clear, step-by-step guide on configuring AWS integrations via Pipes. Key changes include:
- Adding detailed step instructions and section headers for each part of the integration setup.
- Introducing a Manual Setup Guide with CloudFormation templates for creating required IAM roles.
- Updating instructions for verifying credentials and configuring IAM roles in both management and member accounts.
Comments suppressed due to low confidence (1)
docs/integrations/aws.md:57
- [nitpick] The sentence could be rephrased for better clarity. Consider revising to 'For Turbot Pipes customers, ensure the IAM role trust policy includes the Turbot Pipes AWS Account ID:
316881668097.'
- Turbot Pipes customers, you must allow the Turbot Pipes AWS Account ID: `316881668097`
Co-authored-by: Mike Burgess <[email protected]>
Preview Available 🚀Commit Author: Madhushree Ray Preview Link: turbot-com-git-docs-pipesaws-integration-changes-turbot.vercel.app |
There was a problem hiding this comment.
- the format doesn't match the other docs - this is the guardrails guide format (step 1, step 2, etc), and it doesnt match the rest of the pipes docs, or the other sections in this doc
- I thought we discussed using the same headers in the docs as we use in the UI?
- The required format of the external id should be better documented
- Why are we using an API request in the manual setup? should be terraform, not raw API requests. Or we should just omit it entirely
|
@johnsmyth i pushed changes for the suggestions I didn't understand |
It says that it has to start with the organization id - why? Can't it start with the tenant id instead? |
Preview Available 🚀Commit Author: Karan Popat Preview Link: turbot-com-git-docs-pipesaws-integration-changes-turbot.vercel.app |
|
Does this format look good? |
No description provided.