Skip to content

Add aws_emr_studio table #2479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 20, 2025
Merged

Add aws_emr_studio table #2479

merged 5 commits into from
May 20, 2025

Conversation

misraved
Copy link
Contributor

Integration test logs

Logs
Add passing integration test logs here

Example query results

Results
Add example SQL query results here (please include the input queries as well)

@misraved misraved requested review from ParthaI and Copilot April 30, 2025 06:57
@misraved misraved self-assigned this Apr 30, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for querying AWS EMR Studio information by introducing a new table definition along with corresponding documentation and plugin registration updates.

  • Added documentation for the aws_emr_studio table
  • Created table definition in Go with list and get functions
  • Updated plugin registration to include the new table

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
docs/tables/aws_emr_studio.md New documentation file for aws_emr_studio table
aws/table_aws_emr_studio.go New table definition file with list and get functions
aws/plugin.go Updated plugin registration to include aws_emr_studio table
Comments suppressed due to low confidence (1)

aws/table_aws_emr_studio.go:9

  • [nitpick] Using both AWS SDK v2 and v1 in the same file may lead to confusion. Consider consolidating to a single SDK version if possible.
emrv1 "github.com/aws/aws-sdk-go/service/emr"

Copy link
Contributor

@ParthaI ParthaI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @misraved,
The table structure looks good to me. However, I’ve added a couple of suggestions as comments—could you please take a look when you get a chance?

Additionally, I noticed that a few columns such as subnet_ids, vpc_id, user_role, and service_role are not included in the list API call. I believe we’ll need to add a hydrate function for those columns. Could you please verify that?

@misraved misraved requested a review from Copilot May 13, 2025 14:12
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new Steampipe table for querying AWS EMR Studio data along with integration test logs and example SQL queries for different dialects.

  • Adds detailed documentation for the aws_emr_studio table in Markdown.
  • Implements the aws_emr_studio table and its associated hydrate functions in Go.
  • Updates the plugin mapping in aws/plugin.go to register the new table.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
docs/tables/aws_emr_studio.md Adds comprehensive documentation and usage examples for the table.
aws/table_aws_emr_studio.go Implements table definition, list and hydrate functions for EMR Studio.
aws/plugin.go Registers the new aws_emr_studio table within the plugin.
Comments suppressed due to low confidence (1)

aws/table_aws_emr_studio.go:45

  • [nitpick] The table defines both 'studio_arn' and 'arn' columns for the EMR Studio ARN. Consider clarifying their distinct purposes or consolidating them to avoid potential confusion.
                Name:        "studio_arn",

@misraved misraved merged commit ed0ea55 into main May 20, 2025
1 check passed
@misraved misraved deleted the add-emr-studio-table branch May 20, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants