-
Notifications
You must be signed in to change notification settings - Fork 110
Optimize query timing for the table aws_ecr_image_scan_finding #2492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize query timing for the table aws_ecr_image_scan_finding #2492
Conversation
Table docs need to be updated based on feedback. |
Closing this PR since the complex query sill failes with |
…timize-query-timing-for-ecr-image-scanning-finding
…timize-query-timing-for-ecr-image-scanning-finding
There was an issue in Steampipe FDW related to handling I have thoroughly tested this PR against the new Steampipe CLI RC version ( Once the stable version of the Steampipe CLI is officially released with these FDW improvements, this PR will be ready to merge. 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR optimizes query timing for the aws_ecr_image_scan_finding table by streamlining the data retrieval process. Key changes include:
- Removing the ParentHydrate (listAwsEcrImageTags) to read query qualifiers directly.
- Updating KeyColumns requirements for image_tag and image_digest from Optional to AnyOf.
- Refactoring repository and image tag value assignments to use direct qualifier values.
Comments suppressed due to low confidence (3)
aws/table_aws_ecr_image_scan_finding.go:24
- Removing ParentHydrate simplifies the implementation by relying on query qualifiers directly. Confirm that all necessary filtering logic previously provided through the parent function is maintained.
ParentHydrate: listAwsEcrImageTags,
aws/table_aws_ecr_image_scan_finding.go:36
- Changing KeyColumns from Optional to AnyOf for image_tag and image_digest appears to align with the new design. Verify that the updated qualifier requirements work as expected with the query planner.
{Name: "image_tag", Require: plugin.AnyOf},
aws/table_aws_ecr_image_scan_finding.go:144
- Switching to retrieving repositoryName directly from query qualifiers streamlines the input handling. Ensure that the qualifiers are always provided to prevent any potential runtime errors.
RepositoryName: aws.String(repositoryName.GetStringValue()),
Integration test logs
Logs
Example query results
Results