feat: add aws_synthetics_canary_run table - #2768
Conversation
cdea5d2 to
911a586
Compare
|
Hey @leongzhiyong, thanks for the PR! Overall, the table looks to be in good shape. A few suggestions before we merge:
Thanks again! |
582f19d to
ba8b98b
Compare
|
Hi there @cbruno10, thanks for the review!
|
cbruno10
left a comment
There was a problem hiding this comment.
@leongzhiyong - Sorry for the delay in follow-up review. I've added some additional minor comments, and for your question on standard columns (in particular for cloud plugin tables), please see https://steampipe.io/docs/develop/table-docs-standards.
Also, after making the changes, can you please quickly run through at least the postgres example queries you have and make sure they all run and return the correct results? Thanks!
6ec0af6 to
c2a25ed
Compare
|
Made the latest set of requested changes! |
cbruno10
left a comment
There was a problem hiding this comment.
@leongzhiyong Thanks for making the earlier changes! I've left a few more minor suggestions, can you please have a look?
c2a25ed to
1d446c0
Compare
|
All done 👍 |
Integration test logs
Not applicable due to lack of Terraform support for Synthetics canary runs.
Example query results
Results
Closes #2767.