Fix symlink handling in FUSE and overlay filesystem#127
Merged
Conversation
penberg
force-pushed
the
fix-symlink-handling
branch
4 times, most recently
from
403954e to
e9136c5
Compare
The FUSE handlers were using stat() which follows symlinks, causing symlinks to directories to be incorrectly reported as directories. This broke operations like `rm -rf` on pnpm's node_modules which uses symlinks extensively.
penberg
force-pushed
the
fix-symlink-handling
branch
from
e9136c5 to
a76ee73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FUSE handlers were using stat() which follows symlinks, causing symlinks to directories to be incorrectly reported as directories. This broke operations like
rm -rfon pnpm's node_modules which uses symlinks extensively.