-
Notifications
You must be signed in to change notification settings - Fork 7
fix: explain query plan formatting #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
douglasmdev
wants to merge
4
commits into
main
Choose a base branch
from
fix/explain-query-plan-formatting
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
675c70d
feat(statement-result): add query field
douglasmdev 5cc9ad0
feat(statement-result): populate query field on success
douglasmdev 0ab4973
feat(print-statements): intercept explain query plan statements
douglasmdev 8b0663d
feat(tree-builder): add utils for building and printing the tree
douglasmdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
package db | ||
|
||
import ( | ||
"fmt" | ||
) | ||
|
||
type QueryPlanNode struct { | ||
ID string | ||
ParentID string | ||
NotUsed string | ||
Detail string | ||
Children []*QueryPlanNode | ||
} | ||
|
||
func BuildQueryPlanTree(rows [][]string) (*QueryPlanNode, error) { | ||
var nodes []*QueryPlanNode | ||
nodeMap := make(map[string]*QueryPlanNode) | ||
|
||
for _, row := range rows { | ||
id := row[0] | ||
parentId := row[1] | ||
notUsed := row[2] | ||
detail := row[3] | ||
|
||
node := &QueryPlanNode{ | ||
ID: id, | ||
ParentID: parentId, | ||
NotUsed: notUsed, | ||
Detail: detail, | ||
} | ||
|
||
nodes = append(nodes, node) | ||
nodeMap[id] = node | ||
} | ||
|
||
root := &QueryPlanNode{} | ||
for _, node := range nodes { | ||
if node.ParentID == "0" { | ||
root = node | ||
} else { | ||
parent := nodeMap[node.ParentID] | ||
parent.Children = append(parent.Children, node) | ||
} | ||
} | ||
|
||
return root, nil | ||
} | ||
|
||
func PrintQueryPlanTree(node *QueryPlanNode, indent string) { | ||
fmt.Printf("%s%s\n", indent, node.Detail) | ||
for _, child := range node.Children { | ||
PrintQueryPlanTree(child, indent+" ") | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't you be testing the
EXPLAI QUERY PLAN
command?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this is testing that a table with the same column names as the EQP table will still be treated as a normal table (which it should).