Add libsql_open_sync_with_config #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am fine with this, but curious to know if we can make the API simpler with a |
I would have to check. That would also require update to op-sqlite too. |
haaawk
force-pushed
the
bindings_interval_sync
branch
2 times, most recently
from
fe218ef to
70ddf74
Compare
haaawk
changed the title
|
Let me know if this looks better @penberg |
Signed-off-by: Piotr Jastrzebski <[email protected]>
haaawk
force-pushed
the
bindings_interval_sync
branch
from
70ddf74 to
eb94416
Compare
|
I was able to switch go-libsql to use libsql_config and all the tests passed -> tursodatabase/go-libsql#32 |
penberg
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose interval sync in C bindings.
Fixes #1561