Bootstrap database before opening connection #2021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avinassh
force-pushed
the
local-sync
branch
2 times, most recently
from
7af7834 to
0558de3
Compare
avinassh
force-pushed
the
local-sync
branch
2 times, most recently
from
aef6b24 to
9f2b898
Compare
penberg
reviewed
Apr 10, 2025
libsql/examples/remote_sync.rs
Outdated
| let result: String = rows.next().await.unwrap().unwrap().get(0).unwrap(); | ||
| assert_eq!(result, "ok", "integrity check failed after sync"); | ||
| println!("Integrity check passed after sync"); | ||
| } |
There was a problem hiding this comment.
Please drop this and let's instead work on #1998 to do this internally.
penberg
changed the title
|
I think we should just make |
we use the following heuristic to determine if we need to sync the db file 1. if no db file or the metadata file exists, then user is starting from scratch and we will do the sync 2. if the metadata file exists, but the db file does not exist, then local db is in an incorrect state. we stop and return with an error 3. if the db file exists and the metadata file exists, then we don't need to do the sync
If we try to bootstrap the db after a connection is opened, then it is incorrect, as it could create a local .db file and a successful sync would replace this file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is a follow up on #2017 It changes the heuristics for bootstrapping the DB.
One more change is, it also does bootstrap before any connection to the local SQLite is created
Earlier, we bootstrapped whenever we noticed a change in the generation. However, this patch changes this behaviour and does bootstrap only if local files don't exist:
and we will do the sync
then local db is in an incorrect state. we stop and return with an error
sync