This repository was archived by the owner on Jan 6, 2026. It is now read-only.
Merged
Conversation
- otherwise, query like `INSERT INTO t VALUES (1) RETURNING id` will be not finished and result will be rolled back completely in the stmt_reset call
PThorpe92
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrade turso_core to version
0.3.2. This lead to regression, so few places also fixed in order to mitigate new issues.The main issue is that closing rows without error can silently reset all changes made within a statement.
Go bindings for now can hit this behavior in case of
INSERTwithRETURNINGclause as only one row will be consumed before clause for them (but final Done will not be reached)This PR explicitly consume all rows on Close if there were no error for the statement