Replace panic! and assert! with turso_macros assertions#5488
Merged
Conversation
Convert panic!/assert! in turso-stress to turso_assert/turso_assert_unreachable
with structured details blocks, so Antithesis gets proper metadata instead of
baked-in format strings. Also remove redundant format!("{:?}", ...) wrappers
in btree.rs and builder.rs details blocks since the macro already applies Debug
formatting.
https://claude.ai/code/session_012NRC1Tbyaoexyb8PruUQLG
LeMikaelF
requested review from
jussisaurio,
penberg and
pereman2
as code owners
![turso-bot[bot]](https://avatars.githubusercontent.com/in/2434523?s=60&v=4){kind=small}
Collaborator
Author
|
still a draft |
LeMikaelF
commented
Feb 20, 2026
|
|
||
| if overflows { | ||
| *write_state = WriteState::Balancing; | ||
| turso_assert!(matches!(self.balance_state.sub_state, BalanceSubState::Start), "no balancing operation should be in progress during insert", { "state": format!("{:?}", self.state), "sub_state": format!("{:?}", self.balance_state.sub_state) }); |
Collaborator
Author
There was a problem hiding this comment.
The format! here was redundant, because I changed these macros to use Debug.
jussisaurio
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces all instances of
panic!andassert!macros with structured assertion macros fromturso_macros(turso_assert!andturso_assert_unreachable!). These macros provide better error context by including structured metadata about the failure conditions.This will make turso-stress failures easier to read, instead of them looking like this: