PHPStan level 9 #552
Draft
PHPStan level 9 #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turtle0x1
force-pushed
the
phpstan-level-9
branch
3 times, most recently
from
9b650c0 to
9f74673
Compare
There was some null checks added, and some other small tweaks here or there. Tools like rector dont seem to be able to help, so had to fix these by hand. Still 500+ errors (of interest) to clear down. The errors i'm considering "not interesting" are instances of using "array" when I should have been declaring a "class" (Object, Interface, ETC).
turtle0x1
force-pushed
the
phpstan-level-9
branch
from
9f74673 to
52f69b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some null checks added, and some other small tweaks here or there.
Tools like rector dont seem to be able to help, so had to fix these by hand.
Still 500+ errors (of interest) to clear down. The errors i'm considering "not interesting" are instances of using "array" when I should have been declaring a "class" (Object, Interface, ETC).