Skip to content

Commit ba9d90a

Browse files
daltonpearsondaltonpearson
committed
updated tests to work with case insensitive headers per http1.1
1 parent c9f1b2d commit ba9d90a

File tree

8 files changed

+331
-331
lines changed

8 files changed

+331
-331
lines changed

‎test/spec/helpers/utils.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ export class TestRequest {
100100
}
101101

102102
getHeader(header) {
103-
return this.requestHeaders[header.toLowerCase()] || null
103+
return this.requestHeaders[header.toLowerCase()] || undefined
104104
}
105105

106106
setProgressHandler(progressHandler) {

‎test/spec/test-binary-data.js‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -52,43 +52,43 @@ describe('tus', () => {
5252
let req = await testStack.nextRequest()
5353
expect(req.url).toBe('http://tus.io/uploads')
5454
expect(req.method).toBe('POST')
55-
expect(req.requestHeaders['Tus-Resumable']).toBe('1.0.0')
56-
expect(req.requestHeaders['Upload-Length']).toBe('13')
55+
expect(req.getHeader('Tus-Resumable')).toBe('1.0.0')
56+
expect(req.getHeader('Upload-Length')).toBe('13')
5757

5858
req.respondWith({
5959
status: 201,
6060
responseHeaders: {
61-
Location: '/uploads/blargh',
61+
location: '/uploads/blargh',
6262
},
6363
})
6464

6565
req = await testStack.nextRequest()
6666
expect(req.url).toBe('http://tus.io/uploads/blargh')
6767
expect(req.method).toBe('PATCH')
68-
expect(req.requestHeaders['Tus-Resumable']).toBe('1.0.0')
69-
expect(req.requestHeaders['Upload-Offset']).toBe('0')
70-
expect(req.requestHeaders['Content-Type']).toBe('application/offset+octet-stream')
68+
expect(req.getHeader('Tus-Resumable')).toBe('1.0.0')
69+
expect(req.getHeader('Upload-Offset')).toBe('0')
70+
expect(req.getHeader('Content-Type')).toBe('application/offset+octet-stream')
7171
expect(req.bodySize).toBe(7)
7272

7373
req.respondWith({
7474
status: 204,
7575
responseHeaders: {
76-
'Upload-Offset': '7',
76+
'upload-offset': '7',
7777
},
7878
})
7979

8080
req = await testStack.nextRequest()
8181
expect(req.url).toBe('http://tus.io/uploads/blargh')
8282
expect(req.method).toBe('PATCH')
83-
expect(req.requestHeaders['Tus-Resumable']).toBe('1.0.0')
84-
expect(req.requestHeaders['Upload-Offset']).toBe('7')
85-
expect(req.requestHeaders['Content-Type']).toBe('application/offset+octet-stream')
83+
expect(req.getHeader('Tus-Resumable')).toBe('1.0.0')
84+
expect(req.getHeader('Upload-Offset')).toBe('7')
85+
expect(req.getHeader('Content-Type')).toBe('application/offset+octet-stream')
8686
expect(req.bodySize).toBe(6)
8787

8888
req.respondWith({
8989
status: 204,
9090
responseHeaders: {
91-
'Upload-Offset': '13',
91+
'upload-offset': '13',
9292
},
9393
})
9494

‎test/spec/test-browser-specific.js‎

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -45,28 +45,28 @@ describe('tus', () => {
4545
let req = await testStack.nextRequest()
4646
expect(req.url).toBe('http://tus.io/uploads/resuming')
4747
expect(req.method).toBe('HEAD')
48-
expect(req.requestHeaders['Tus-Resumable']).toBe('1.0.0')
48+
expect(req.getHeader('Tus-Resumable')).toBe('1.0.0')
4949

5050
req.respondWith({
5151
status: 204,
5252
responseHeaders: {
53-
'Upload-Length': '11',
54-
'Upload-Offset': '3',
53+
'upload-length': '11',
54+
'upload-offset': '3',
5555
},
5656
})
5757

5858
req = await testStack.nextRequest()
5959
expect(req.url).toBe('http://tus.io/uploads/resuming')
6060
expect(req.method).toBe('PATCH')
61-
expect(req.requestHeaders['Tus-Resumable']).toBe('1.0.0')
62-
expect(req.requestHeaders['Upload-Offset']).toBe('3')
63-
expect(req.requestHeaders['Content-Type']).toBe('application/offset+octet-stream')
61+
expect(req.getHeader('Tus-Resumable')).toBe('1.0.0')
62+
expect(req.getHeader('Upload-Offset')).toBe('3')
63+
expect(req.getHeader('Content-Type')).toBe('application/offset+octet-stream')
6464
expect(req.bodySize).toBe(11 - 3)
6565

6666
req.respondWith({
6767
status: 204,
6868
responseHeaders: {
69-
'Upload-Offset': '11',
69+
'upload-offset': '11',
7070
},
7171
})
7272

@@ -99,7 +99,7 @@ describe('tus', () => {
9999
req.respondWith({
100100
status: 201,
101101
responseHeaders: {
102-
Location: '/uploads/blargh',
102+
location: '/uploads/blargh',
103103
},
104104
})
105105

@@ -115,7 +115,7 @@ describe('tus', () => {
115115
req.respondWith({
116116
status: 204,
117117
responseHeaders: {
118-
'Upload-Offset': '11',
118+
'upload-offset': '11',
119119
},
120120
})
121121

@@ -172,13 +172,13 @@ describe('tus', () => {
172172
let req = await testStack.nextRequest()
173173
expect(req.url).toBe('http://tus.io/uploads/storedUrl')
174174
expect(req.method).toBe('HEAD')
175-
expect(req.requestHeaders['Tus-Resumable']).toBe('1.0.0')
175+
expect(req.getHeader('Tus-Resumable')).toBe('1.0.0')
176176

177177
req.respondWith({
178178
status: 204,
179179
responseHeaders: {
180-
'Upload-Length': '11',
181-
'Upload-Offset': '3',
180+
'upload-length': '11',
181+
'upload-offset': '3',
182182
},
183183
})
184184

@@ -195,15 +195,15 @@ describe('tus', () => {
195195
req = await testStack.nextRequest()
196196
expect(req.url).toBe('http://tus.io/uploads/storedUrl')
197197
expect(req.method).toBe('PATCH')
198-
expect(req.requestHeaders['Tus-Resumable']).toBe('1.0.0')
199-
expect(req.requestHeaders['Upload-Offset']).toBe('3')
200-
expect(req.requestHeaders['Content-Type']).toBe('application/offset+octet-stream')
198+
expect(req.getHeader('Tus-Resumable')).toBe('1.0.0')
199+
expect(req.getHeader('Upload-Offset')).toBe('3')
200+
expect(req.getHeader('Content-Type')).toBe('application/offset+octet-stream')
201201
expect(req.bodySize).toBe(11 - 3)
202202

203203
req.respondWith({
204204
status: 204,
205205
responseHeaders: {
206-
'Upload-Offset': '11',
206+
'upload-offset': '11',
207207
},
208208
})
209209

@@ -299,36 +299,36 @@ describe('tus', () => {
299299
req.respondWith({
300300
status: 200,
301301
responseHeaders: {
302-
'Upload-Length': '11',
303-
'Upload-Offset': '3',
302+
'upload-length': '11',
303+
'upload-offset': '3',
304304
},
305305
response: new Blob('hello world'.split('')),
306306
})
307307

308308
req = await testStack.nextRequest()
309309
expect(req.url).toBe('http://tus.io/uploads')
310310
expect(req.method).toBe('POST')
311-
expect(req.requestHeaders['Upload-Length']).toBe('11')
311+
expect(req.getHeader('Upload-Length')).toBe('11')
312312

313313
req.respondWith({
314314
status: 201,
315315
responseHeaders: {
316-
Location: '/uploads/blargh',
316+
location: '/uploads/blargh',
317317
},
318318
})
319319

320320
req = await testStack.nextRequest()
321321
expect(req.url).toBe('http://tus.io/uploads/blargh')
322322
expect(req.method).toBe('PATCH')
323-
expect(req.requestHeaders['Tus-Resumable']).toBe('1.0.0')
324-
expect(req.requestHeaders['Upload-Offset']).toBe('0')
325-
expect(req.requestHeaders['Content-Type']).toBe('application/offset+octet-stream')
323+
expect(req.getHeader('Tus-Resumable')).toBe('1.0.0')
324+
expect(req.getHeader('Upload-Offset')).toBe('0')
325+
expect(req.getHeader('Content-Type')).toBe('application/offset+octet-stream')
326326
expect(req.bodySize).toBe(11)
327327

328328
req.respondWith({
329329
status: 204,
330330
responseHeaders: {
331-
'Upload-Offset': '11',
331+
'upload-offset': '11',
332332
},
333333
})
334334

0 commit comments

Comments
 (0)