Skip to content

WIP: Make Header Indexing Case-Insensitive in tus Client #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
daltonpearson wants to merge 1 commit into from
+9 −3
Closed

WIP: Make Header Indexing Case-Insensitive in tus Client #812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/browser/FetchHttpStack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ class FetchResponse implements HttpResponse {
}

getHeader(header: string): string | undefined {
return this._res.headers.get(header) || undefined
return this._res.headers.get(header) || this._res.headers.get(header.toLowerCase()) || undefined
}

getBody(): string {
Expand Down
6 changes: 5 additions & 1 deletion lib/browser/XHRHttpStack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,11 @@ class XHRResponse implements HttpResponse {
}

getHeader(header: string): string | undefined {
return this._xhr.getResponseHeader(header) || undefined
return (
this._xhr.getResponseHeader(header) ||
this._xhr.getResponseHeader(header.toLowerCase()) ||
undefined
)
}

getBody(): string {
Expand Down
4 changes: 3 additions & 1 deletion test/spec/helpers/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,9 @@ export class TestResponse {
}

getHeader(header) {
return this._response.responseHeaders[header]
return (
this._response.responseHeaders[header] || this._response.responseHeaders[header.toLowerCase()]
)
}

getBody() {
Expand Down
Loading