Skip to content

Remove disabled methods from headers #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Remove disabled methods from headers #1296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/handler/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ func NewHandler(config Config) (*Handler, error) {
UnroutedHandler: handler,
}

// allowedMethods := []string{""}

mux := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
method := r.Method
path := strings.Trim(r.URL.Path, "/")
Expand Down Expand Up @@ -64,6 +66,7 @@ func NewHandler(config Config) (*Handler, error) {
handler.DelFile(w, r)
default:
// TODO: Only add GET and DELETE if they are supported
// TODO: POST with X-Method-Override is allowed
w.Header().Add("Allow", "GET, HEAD, PATCH, DELETE")
w.WriteHeader(http.StatusMethodNotAllowed)
w.Write([]byte(`method not allowed`))
Expand Down
2 changes: 1 addition & 1 deletion pkg/handler/unrouted_handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ func (handler *UnroutedHandler) Middleware(h http.Handler) http.Handler {
// Allow overriding the HTTP method. The reason for this is
// that some libraries/environments do not support PATCH and
// DELETE requests, e.g. Flash in a browser and parts of Java.
if newMethod := r.Header.Get("X-HTTP-Method-Override"); r.Method == "POST" && newMethod != "" {
if newMethod := r.Header.Get("X-HTTP-Method-Override"); r.Method == "POST" && (newMethod == "PATCH" || newMethod == "DELETE") {
r.Method = newMethod
}

Expand Down
Loading