build(deps): use std or local helper to simplify deps#1343
build(deps): use std or local helper to simplify deps#1343ferhatelmas wants to merge 1 commit intotus:mainfrom
Conversation
* use more testify for denser code which also drops x/exp constraints reference (only for e2e since other changes touch) * use std for slog/slices instead of x/exp * use a simple tcp proxy to drop toxiproxy/zerolog which are only used for e2e tests otherwise Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
2597737 to
843ec55
Compare
|
Thank you for looking into this!
|
I agree for technicality but it's in the same realm with bumping required minimum go version, this already breaks some applications.
usage here is minimal but it brings big dependencies such as zap. Also, it doesn't get attention for maintenance recently. I would advocate dropping/replacing so this PR is. Regarding better API, it could be done in two steps, replace existing and then improve. |
I would argue that bumping the Go version is different, since we publicly announce to only support the two last minor releases of Go. Which is also quite common in the Go ecosystem, I feel. Would you be open to splitting this PR into different ones? One for dropping |
|
sure
|
use more testify for denser code which also drops x/exp constraints reference (only for e2e since other changes touch)
use std for slog/slices instead of x/exp
use a simple tcp proxy to drop toxiproxy/zerolog which are only used for e2e tests otherwise